[webkit-reviews] review granted: [Bug 190487] [iOS] WebKit should dispatch DOM events when a modifier key is pressed : [Attachment 353432] Patch and test

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 190487: [iOS] WebKit should dispatch DOM events when a modifier key is
pressed
https://bugs.webkit.org/show_bug.cgi?id=190487

Attachment 353432: Patch and test

https://bugs.webkit.org/attachment.cgi?id=353432&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 353432
  --> https://bugs.webkit.org/attachment.cgi?id=353432
Patch and test

View in context: https://bugs.webkit.org/attachment.cgi?id=353432&action=review

> Source/WebCore/platform/ios/WebEvent.h:59
> +// These enum values are copied directly from GSEvent for compatibility.

Really?

> Source/WebCore/platform/ios/WebEvent.h:87
> +// These enum values are copied directly from GSEvent for compatibility.

Don't look "copied directly" to me.

> Tools/ChangeLog:8
> +	   Update the code for renamed enumerators. For WebKitTestRunner,
removed comment that does not

Is this "enumerations" not "enumerators"?