[webkit-reviews] review granted: [Bug 191120] [iOS] Normalize character string based on key code : [Attachment 353504] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 16:25:20 PDT 2018


Tim Horton <thorton at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 191120: [iOS] Normalize character string based on key code
https://bugs.webkit.org/show_bug.cgi?id=191120

Attachment 353504: Patch

https://bugs.webkit.org/attachment.cgi?id=353504&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 353504
  --> https://bugs.webkit.org/attachment.cgi?id=353504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353504&action=review

> Source/WebCore/platform/ios/WebEvent.mm:127
> +static NSString* normalizedStringWithAppKitCompatibilityMapping(NSString
*characters, uint16_t keyCode)

Not new, but star's on the wrong side.


More information about the webkit-reviews mailing list