[webkit-reviews] review granted: [Bug 186146] [GTK] Switch to use a popup window with a tree view instead of a menu for option menu default implementation : [Attachment 341660] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 186146: [GTK] Switch to use a popup window with a tree view instead of a
menu for option menu default implementation
https://bugs.webkit.org/show_bug.cgi?id=186146

Attachment 341660: Patch

https://bugs.webkit.org/attachment.cgi?id=341660&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 341660
  --> https://bugs.webkit.org/attachment.cgi?id=341660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341660&action=review

> Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:274
> +    // FIXME: We can't ensure the menu will be on screen in Wayland.
> +    //
https://blog.gtk.org/2016/07/15/future-of-relative-window-positioning/
> +    // https://gitlab.gnome.org/GNOME/gtk/issues/997
> +    if (menuPosition.x() < area.x)
> +	   menuPosition.setX(area.x);
> +    else if (menuPosition.x() + menuRequisition.width > area.x + area.width)
> +	   menuPosition.setX(area.x + area.width - menuRequisition.width);

You need the important fix from
https://gitlab.gnome.org/GNOME/epiphany/commit/37b9c6e69950729981c352e245772f2e
51c9d78f for the multimonitor users.

And I guess you'll remove EphyOptionMenu after the next release.