[webkit-reviews] review granted: [Bug 185929] [ESNext][BigInt] Implement support for "=<" and ">=" relational operation : [Attachment 341638] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 185929: [ESNext][BigInt] Implement support for "=<" and ">=" relational
operation
https://bugs.webkit.org/show_bug.cgi?id=185929

Attachment 341638: Patch

https://bugs.webkit.org/attachment.cgi?id=341638&action=review




--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 341638
  --> https://bugs.webkit.org/attachment.cgi?id=341638
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341638&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/Operations.h:324
> +	       bool result = bigIntCompare(callFrame, p1, p2,
JSBigInt::ComparisonMode::LessThanOrEqual);
> +	       RETURN_IF_EXCEPTION(scope, false);
> +	       return result;

Just do,

scope.release();
return bigIntCompare(callFrame, p1, p2,
JSBigInt::ComparisonMode::LessThanOrEqual);