[webkit-reviews] review granted: [Bug 185958] NavigationAction does not need to hold initiating DOM Event : [Attachment 341356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 17:08:39 PDT 2018

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 185958: NavigationAction does not need to hold initiating DOM Event

Attachment 341356: Patch


--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 341356
  --> https://bugs.webkit.org/attachment.cgi?id=341356

View in context: https://bugs.webkit.org/attachment.cgi?id=341356&action=review

> Source/WebCore/loader/NavigationAction.cpp:96
>  NavigationAction::NavigationAction(Document& requester, const
ResourceRequest& resourceRequest, InitiatedByMainFrame initiatedByMainFrame,
NavigationType type, ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy,
Event* event, const AtomicString& downloadAttribute)

Maybe add a comment in the header file to say that this class shouldn't hold on
to any objects from the originating document.

> Source/WebCore/loader/NavigationAction.h:93
> +	   bool buttonDown;
> +	   unsigned short button;
> +	   unsigned short syntheticClickType;
> +	   LayoutPoint absoluteLocation;
> +	   FloatPoint locationInRootViewCoordinates;

This would pack better with the larger types first.

More information about the webkit-reviews mailing list