[webkit-reviews] review granted: [Bug 183338] Follow-up fixes after r228907. : [Attachment 341350] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183338: Follow-up fixes after r228907.
https://bugs.webkit.org/show_bug.cgi?id=183338

Attachment 341350: Patch

https://bugs.webkit.org/attachment.cgi?id=341350&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 341350
  --> https://bugs.webkit.org/attachment.cgi?id=341350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341350&action=review

I think this change to the launch code might fix a bug David and I have been
trying to track down! r=me, but please make sure EWS is happy before landing.

> Source/WebKit/Shared/WebProcessCreationParameters.h:199
> +    HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties>
screenPropertiesMap;

We use HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> a lot in
PlatformScreen. I wonder if we should define a type for this to keep things
tidy?