[webkit-reviews] review denied: [Bug 144525] DFG::LICMPhase should attempt to hoist edge type checks if hoisting the whole node fails : [Attachment 340832] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 11:10:56 PDT 2018


Saam Barati <sbarati at apple.com> has denied Saam Barati <sbarati at apple.com>'s
request for review:
Bug 144525: DFG::LICMPhase should attempt to hoist edge type checks if hoisting
the whole node fails
https://bugs.webkit.org/show_bug.cgi?id=144525

Attachment 340832: patch

https://bugs.webkit.org/attachment.cgi?id=340832&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340832
  --> https://bugs.webkit.org/attachment.cgi?id=340832
patch

This doesn't do check hoisting on nodes that write. That's wrong...


More information about the webkit-reviews mailing list