[webkit-reviews] review denied: [Bug 185757] Don't create the SubimageCache just to clear an image from it : [Attachment 340863] Patch v2

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 185757: Don't create the SubimageCache just to clear an image from it
https://bugs.webkit.org/show_bug.cgi?id=185757

Attachment 340863: Patch v2

https://bugs.webkit.org/attachment.cgi?id=340863&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 340863
  --> https://bugs.webkit.org/attachment.cgi?id=340863
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=340863&action=review

> Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h:89
> +    static bool cacheExists();
> +    static SubimageCacheWithTimer& getCache();

Usually we have getCache() and getExistingCache(), which I prefer.