[webkit-reviews] review granted: [Bug 183329] Improve how Gigacage reserves address space on Linux : [Attachment 340850] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183329: Improve how Gigacage reserves address space on Linux
https://bugs.webkit.org/show_bug.cgi?id=183329

Attachment 340850: Patch

https://bugs.webkit.org/attachment.cgi?id=340850&action=review




--- Comment #43 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340850
  --> https://bugs.webkit.org/attachment.cgi?id=340850
Patch

Well I'm not sure if we should do this, because Gigacage is an important
security feature. There are some notes at
https://labs.mwrinfosecurity.com/blog/some-brief-notes-on-webkit-heap-hardening
/ about all the hardening features that this will silently disable.

But I guess not crashing is good, so r=me.

Did you try Florian's suggestion? Were there problems with performance?