[webkit-reviews] review granted: [Bug 185818] [GTK][Wayland] UI process crash when closing the window : [Attachment 340839] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 07:05:31 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 185818: [GTK][Wayland] UI process crash when closing the window
https://bugs.webkit.org/show_bug.cgi?id=185818

Attachment 340839: Patch

https://bugs.webkit.org/attachment.cgi?id=340839&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340839
  --> https://bugs.webkit.org/attachment.cgi?id=340839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340839&action=review

> Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp:93
> +    if (enabled && m_page->isViewFocused())
>	   notifyFocusedIn();

Do you think there's a GTK+ bug here, too? I guess so, because it seems really
odd that this could avoid a crash deep in GTK+.


More information about the webkit-reviews mailing list