[webkit-reviews] review denied: [Bug 185601] [JSC] Check TypeOfShouldCallGetCallData before calling getCallData when we would like to check whether a given object is callable : [Attachment 340323] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 10:19:15 PDT 2018


Saam Barati <sbarati at apple.com> has denied  review:
Bug 185601: [JSC] Check TypeOfShouldCallGetCallData before calling getCallData
when we would like to check whether a given object is callable
https://bugs.webkit.org/show_bug.cgi?id=185601

Attachment 340323: Patch

https://bugs.webkit.org/attachment.cgi?id=340323&action=review




--- Comment #16 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340323
  --> https://bugs.webkit.org/attachment.cgi?id=340323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340323&action=review

> Source/JavaScriptCore/ChangeLog:16
> +	   To do this cleanly, we refactor JSValue::{isFunction,isCallable}. We
add JSCell::{isFunction,isCallable}
> +	   and JSValue ones call into these functions. Inside
JSCell::{isFunction,isCallable}, we perform
> +	   TypeOfShouldCallGetCallData checking before calling getCallData.

Hold on, this doesn't seem quite right. I don't think being callable should
depend on the TypeOfShouldCallGetCallData being set.


More information about the webkit-reviews mailing list