[webkit-reviews] review granted: [Bug 185601] [JSC] Check TypeOfShouldCallGetCallData before calling getCallData when we would like to check whether a given object is callable : [Attachment 340323] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185601: [JSC] Check TypeOfShouldCallGetCallData before calling getCallData
when we would like to check whether a given object is callable
https://bugs.webkit.org/show_bug.cgi?id=185601

Attachment 340323: Patch

https://bugs.webkit.org/attachment.cgi?id=340323&action=review




--- Comment #15 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340323
  --> https://bugs.webkit.org/attachment.cgi?id=340323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340323&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] Check TypeOfShouldCallGetCallData before calling getCallData
when we would like to check whether a given object is callable

I would make the name of this line up with your functions:
"given object is callable" => "given object is a function"