[webkit-reviews] review granted: [Bug 185541] [JSC] Tweak LiteralParser to improve lexing performance : [Attachment 340172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 09:13:30 PDT 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185541: [JSC] Tweak LiteralParser to improve lexing performance
https://bugs.webkit.org/show_bug.cgi?id=185541

Attachment 340172: Patch

https://bugs.webkit.org/attachment.cgi?id=340172&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340172
  --> https://bugs.webkit.org/attachment.cgi?id=340172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340172&action=review

r=me

> Source/JavaScriptCore/runtime/LiteralParser.cpp:501
> +	   default:

Maybe add a debug assert of what the token types are here just for
documentation?


More information about the webkit-reviews mailing list