[webkit-reviews] review denied: [Bug 185592] [MSE][GStreamer] Before deleting the stream from WebKitMediaSource we should unlink its elements and flush the appsrc. : [Attachment 340280] Patch

[bugzilla-daemon at webkit.org]

Alicia Boya García <aboya at igalia.com> has denied Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 185592: [MSE][GStreamer] Before deleting the stream from WebKitMediaSource
we should unlink its elements and flush the appsrc.
https://bugs.webkit.org/show_bug.cgi?id=185592

Attachment 340280: Patch

https://bugs.webkit.org/attachment.cgi?id=340280&action=review




--- Comment #10 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 340280
  --> https://bugs.webkit.org/attachment.cgi?id=340280
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340280&action=review

>
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:5
40
> +	       return;

This is the reason your patch removes the wait for the background thread.
Flushing an unlinked element is an error, therefore gst_element_send_event()
returns != 0 and the function returns here, not reaching
`gst_element_set_state(stream->appsrc, GST_STATE_NULL);` which is a few lines
below.

With the patch the pipeline state is not changed to NULL, therefore the
streaming thread is not finished -- and incidentally, no wait for its
termination occurs.