[webkit-reviews] review requested: [Bug 185511] [GTK] Implement ImageBuffer::toBGRAData : [Attachment 340088] (In reply to Michael Catanzaro from comment #3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 07:06:34 PDT 2018


Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 185511: [GTK] Implement ImageBuffer::toBGRAData
https://bugs.webkit.org/show_bug.cgi?id=185511

Attachment 340088: (In reply to Michael Catanzaro from comment #3)

https://bugs.webkit.org/attachment.cgi?id=340088&action=review




--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 340088

  --> https://bugs.webkit.org/attachment.cgi?id=340088&action=review

(In reply to Michael Catanzaro from comment #3)

> Comment on attachment 340087 [details]
> Minor typo fix since previous version.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340087&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +	     [GTK] Implement ImageBuffer::toBGRAData
> 
> The commit title doesn't belong here, you already have it properly up at the
> top.

Not sure how that happened, I just used prepareChangeLog, anyway Fixed.

> > Source/WebCore/platform/graphics/ImageBuffer.cpp:105
> > +#if USE(CG) && !PLATFORM(GTK)
> 
> Move the CG implementation to ImageBufferCG.cpp, then this condition can
> become #if !USE(CG) && !PLATFORM(GTK).

Done.


More information about the webkit-reviews mailing list