[webkit-reviews] review granted: [Bug 185511] [GTK] Implement ImageBuffer::toBGRAData : [Attachment 340087] Minor typo fix since previous version.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 10 06:44:52 PDT 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 185511: [GTK] Implement ImageBuffer::toBGRAData
https://bugs.webkit.org/show_bug.cgi?id=185511
Attachment 340087: Minor typo fix since previous version.
https://bugs.webkit.org/attachment.cgi?id=340087&action=review
--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340087
--> https://bugs.webkit.org/attachment.cgi?id=340087
Minor typo fix since previous version.
View in context: https://bugs.webkit.org/attachment.cgi?id=340087&action=review
> Source/WebCore/ChangeLog:8
> + [GTK] Implement ImageBuffer::toBGRAData
The commit title doesn't belong here, you already have it properly up at the
top.
> Source/WebCore/platform/graphics/ImageBuffer.cpp:105
> +#if USE(CG) && !PLATFORM(GTK)
Move the CG implementation to ImageBufferCG.cpp, then this condition can become
#if !USE(CG) && !PLATFORM(GTK).
More information about the webkit-reviews
mailing list