[webkit-reviews] review granted: [Bug 184163] Use MacroAssemblerCodePtr in Wasm code for code pointers instead of void*. : [Attachment 336820] proposed patch.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted  review:
Bug 184163: Use MacroAssemblerCodePtr in Wasm code for code pointers instead of
void*.
https://bugs.webkit.org/show_bug.cgi?id=184163

Attachment 336820: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=336820&action=review




--- Comment #7 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 336820
  --> https://bugs.webkit.org/attachment.cgi?id=336820
proposed patch.

(In reply to Mark Lam from comment #6)
> Comment on attachment 336820 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336820&action=review
> 
> Thanks for the review.
> 
> >> Source/JavaScriptCore/wasm/WasmBinding.cpp:79
> >> +	  jit.xorPtr(JIT::TrustedImmPtr(g_JITCodePoison), scratch);
> > 
> > if (Options::usePoisoning())
> 
> Technically, this is not wrong.  If !Options::usePoisoning(), the poison
> value is guaranteed to be 0.	Hence, this xorPtr has no effect.  However, it
> is less efficient.  I will fix it.  Thanks for the catch.

Right, r+ then, with change.