[webkit-reviews] review denied: [Bug 184163] Use MacroAssemblerCodePtr in Wasm code for code pointers instead of void*. : [Attachment 336820] proposed patch.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 184163: Use MacroAssemblerCodePtr in Wasm code for code pointers instead of
void*.
https://bugs.webkit.org/show_bug.cgi?id=184163

Attachment 336820: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=336820&action=review




--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 336820
  --> https://bugs.webkit.org/attachment.cgi?id=336820
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336820&action=review

This is really great, cleans up the code a bunch :)

r=me with one comment addressed. r- for now because I think it's wrong without
the fix.

> Source/JavaScriptCore/wasm/WasmBinding.cpp:79
> +    jit.xorPtr(JIT::TrustedImmPtr(g_JITCodePoison), scratch);

if (Options::usePoisoning())