[webkit-reviews] review denied: [Bug 183768] Expose content attributes on _WKLinkIconParameters : [Attachment 336103] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 183768: Expose content attributes on _WKLinkIconParameters
https://bugs.webkit.org/show_bug.cgi?id=183768

Attachment 336103: Patch

https://bugs.webkit.org/attachment.cgi?id=336103&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 336103
  --> https://bugs.webkit.org/attachment.cgi?id=336103
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336103&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKLinkIconParameters.mm:66
> +	   _attributes.get()[[(NSString *)attribute.key copy]] = [(NSString
*)attribute.value copy];

This looks like a memory leak.	Why are you copying the NSStrings? 
WTF::String::operator NSString* returns an NSString you could probably just use
without copying.