[webkit-reviews] review granted: [Bug 183723] Disconnect the SVGPathSegList items from their SVGPathElement before rebuilding a new list : [Attachment 336081] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 183723: Disconnect the SVGPathSegList items from their SVGPathElement
before rebuilding a new list
https://bugs.webkit.org/show_bug.cgi?id=183723

Attachment 336081: Patch

https://bugs.webkit.org/attachment.cgi?id=336081&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 336081
  --> https://bugs.webkit.org/attachment.cgi?id=336081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336081&action=review

> Source/WebCore/ChangeLog:11
> +	   segments should be disconnected from the path element. We already do


"should be" is ambiguous: it could mean "they are not disconnected but they
need to be", or "if things are working correctly they will be". Maybe say "they
need to get disconnected".