[webkit-reviews] review requested: [Bug 180390] [build.webkit.org] unit-tests fail when passwords.json is missing : [Attachment 335970] Updated patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 180390: [build.webkit.org] unit-tests fail when passwords.json is missing
https://bugs.webkit.org/show_bug.cgi?id=180390

Attachment 335970: Updated patch

https://bugs.webkit.org/attachment.cgi?id=335970&action=review




--- Comment #7 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 335970

  --> https://bugs.webkit.org/attachment.cgi?id=335970&action=review

Updated patch

> I like it when names help achieve correct grammar. If the variable were
called test_mode_is_enabled, then we'd have "if test_mode_is_enabled" here,
which reads better.
Done

> Not new with this patch, but s/dependant/dependent/.
Replaced

> What was the problem with this? It seems like a nicer way to mock, as we
don't need to pass additional arguments.
The globals() method to mock was working earlier when all the code was in
master.cfg and we were doing execfile(master.cfg). It doesn't work anymore
(after https://trac.webkit.org/r225433), since the file loading is now done in
loadConfig.py, which doesn't have the same globals.