[webkit-reviews] review granted: [Bug 183546] Put the DOM in IsoHeaps : [Attachment 335969] correct patch without changes to IsoHeap algorithm, but with a runtime disable option (bmalloc_IsoHeap=0)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 183546: Put the DOM in IsoHeaps
https://bugs.webkit.org/show_bug.cgi?id=183546

Attachment 335969: correct patch without changes to IsoHeap algorithm, but with
a runtime disable option (bmalloc_IsoHeap=0)

https://bugs.webkit.org/attachment.cgi?id=335969&action=review




--- Comment #60 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 335969
  --> https://bugs.webkit.org/attachment.cgi?id=335969
correct patch without changes to IsoHeap algorithm, but with a runtime disable
option (bmalloc_IsoHeap=0)

View in context: https://bugs.webkit.org/attachment.cgi?id=335969&action=review

> Source/bmalloc/bmalloc/IsoTLS.cpp:205
> +    const char* env = getenv("bmalloc_IsoHeap");
> +    if (env && (!strcasecmp(env, "false") || !strcasecmp(env, "no") ||
!strcmp(env, "0")))
> +	   s_mallocFallbackState = MallocFallbackState::FallBackToMalloc;
> +    else
> +	   s_mallocFallbackState = MallocFallbackState::DoNotFallBack;

Should this be using dispatch_once or whatever?