[webkit-reviews] review granted: [Bug 183372] Get rid of custom bindings for History's replaceState() / pushState() : [Attachment 335134] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183372: Get rid of custom bindings for History's replaceState() /
pushState()
https://bugs.webkit.org/show_bug.cgi?id=183372

Attachment 335134: Patch

https://bugs.webkit.org/attachment.cgi?id=335134&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335134
  --> https://bugs.webkit.org/attachment.cgi?id=335134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335134&action=review

> Source/WebCore/page/History.cpp:175
> +    m_cachedState = { };

It is not clear to me that why we need to clear m_cachedState here.  Is it an
optimization? Or is stateChanged() not be true?