[webkit-reviews] review granted: [Bug 183017] Templatize SVGAnimatedType : [Attachment 335008] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 183017: Templatize SVGAnimatedType
https://bugs.webkit.org/show_bug.cgi?id=183017

Attachment 335008: Patch

https://bugs.webkit.org/attachment.cgi?id=335008&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335008
  --> https://bugs.webkit.org/attachment.cgi?id=335008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335008&action=review

> Source/WebCore/svg/SVGAnimatedAngle.cpp:83
> +    const auto& fromAngleAndEnumeration =
(m_animationElement->animationMode() == ToAnimation ? animated :
from)->as<std::pair<SVGAngleValue, unsigned>>();

Given that you have to call this test so often, maybe it could be a helper?

m_animationElement->isToAnimation() ? animated : from