[webkit-reviews] review granted: [Bug 187153] Early return when handling fetch event in case service worker origin does not match origin of a subresource load : [Attachment 343850] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 187153: Early return when handling fetch event in case service worker
origin does not match origin of a subresource load
https://bugs.webkit.org/show_bug.cgi?id=187153

Attachment 343850: Patch

https://bugs.webkit.org/attachment.cgi?id=343850&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 343850
  --> https://bugs.webkit.org/attachment.cgi?id=343850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343850&action=review

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:195
> +	   RELEASE_ASSERT_WITH_MESSAGE(request.url().host() ==
serviceWorkerURL.host(), "Hosts do not match");

I think we may want this one first as it is the most important, no?

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:205
> +	   ASSERT(url.host() == serviceWorkerURL.host());

ditto.