[webkit-reviews] review granted: [Bug 186093] For <video> element, use video fullscreen instead of element fullscreen. : [Attachment 343823] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 186093: For <video> element, use video fullscreen instead of element
fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=186093

Attachment 343823: Patch

https://bugs.webkit.org/attachment.cgi?id=343823&action=review




--- Comment #10 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 343823
  --> https://bugs.webkit.org/attachment.cgi?id=343823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343823&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:198
> +    document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug,
"For <video> element use webkitSetPresentationMode('Fullscreen') instead of
webkitRequestFullscreen()."_s);

Nit -> "Fullscreen" should be "fullscreen".

We should probably make this non-imperative. Like, "For <video> element use,
webkitRequestFullscreen() will use webkitSetPresentationMode('Fullscreen')".