[webkit-reviews] review granted: [Bug 187112] Add a simulated crash to try to find why we're crashing in repatchPutById : [Attachment 343756] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 187112: Add a simulated crash to try to find why we're crashing in
repatchPutById
https://bugs.webkit.org/show_bug.cgi?id=187112

Attachment 343756: patch

https://bugs.webkit.org/attachment.cgi?id=343756&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 343756
  --> https://bugs.webkit.org/attachment.cgi?id=343756
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343756&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:590
> +			   if (offset != conditionSetOffset) {

Add UNLIKELY() around the condition?