[webkit-reviews] review granted: [Bug 186900] Fix IBeam issues with iPad apps on Mac : [Attachment 343665] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 186900: Fix IBeam issues with iPad apps on Mac
https://bugs.webkit.org/show_bug.cgi?id=186900

Attachment 343665: Patch

https://bugs.webkit.org/attachment.cgi?id=343665&action=review




--- Comment #21 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 343665
  --> https://bugs.webkit.org/attachment.cgi?id=343665
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343665&action=review

> Source/WebKit/Shared/ios/InteractionInformationRequest.cpp:71
> +bool InteractionInformationRequest::isApproximateForRequest(const
InteractionInformationRequest& other)

Nit - as Tim mentioned earlier, I think isApproximatelyValidForRequest is a
more appropriate name here.