[webkit-reviews] review denied: [Bug 185783] test262/Runner.pm: add unit tests : [Attachment 342196] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 11 18:15:41 PDT 2018
Michael Saboff <msaboff at apple.com> has denied valerie <valerie at bocoup.com>'s
request for review:
Bug 185783: test262/Runner.pm: add unit tests
https://bugs.webkit.org/show_bug.cgi?id=185783
Attachment 342196: Patch
https://bugs.webkit.org/attachment.cgi?id=342196&action=review
--- Comment #41 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 342196
--> https://bugs.webkit.org/attachment.cgi?id=342196
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=342196&action=review
Move the BSD license text into the source files that reference it, then delete
the LICENSE file. After that, I think you are good to go.
> Tools/Scripts/webkitperl/test262_unittest/fixtures/test/LICENSE:26
> +Copyright (C) 2018 Bocoup LLC. All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions
> +are met:
> +
> +1. Redistributions of source code must retain the above
> + copyright notice, this list of conditions and the following
> + disclaimer.
> +2. Redistributions in binary form must reproduce the above
> + copyright notice, this list of conditions and the following
> + disclaimer in the documentation and/or other materials
> + provided with the distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER "AS IS" AND ANY
> +EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> +PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE
> +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
> +OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
> +PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
> +PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> +TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> +THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> +SUCH DAMAGE.
Instead of referencing this file, include the license text directly at the top
of each file. Then delete this file.
>
Tools/Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-fa
iling-with-new-error.js:2
> +// This code is governed by the BSD license found in the LICENSE file.
Include the BSD license text directly here and in every other file where you
reference the LICENSE file.
More information about the webkit-reviews
mailing list