[webkit-reviews] review denied: [Bug 186399] test262/Runner.pm: minor updates : [Attachment 342183] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied valerie <valerie at bocoup.com>'s
request for review:
Bug 186399: test262/Runner.pm: minor updates
https://bugs.webkit.org/show_bug.cgi?id=186399

Attachment 342183: Patch

https://bugs.webkit.org/attachment.cgi?id=342183&action=review




--- Comment #5 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 342183
  --> https://bugs.webkit.org/attachment.cgi?id=342183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342183&action=review

Basically fine after addressing a few issues.

> Tools/ChangeLog:7
> +	   - If harness files cannot be found in a custom, supplies
> +	   test262 path, then default to webkit's test262 harness files.

I don't quite understand "in a custom, supplies test262 path,"

> Tools/Scripts/test262/Runner.pm:96
>  my $expectationsFile =
abs_path("$Bin/../../../JSTests/test262/expectations.yaml");
>  my $configFile = abs_path("$Bin/../../../JSTests/test262/config.yaml");

It seems to make sense to have these paths be based on $webkitTest262Dir.