[webkit-reviews] review granted: [Bug 186379] Run display links in the UI process when ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) is true. : [Attachment 342110] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 186379: Run display links in the UI process when
ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) is true.
https://bugs.webkit.org/show_bug.cgi?id=186379

Attachment 342110: Patch

https://bugs.webkit.org/attachment.cgi?id=342110&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 342110
  --> https://bugs.webkit.org/attachment.cgi?id=342110
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342110&action=review

Looks good.

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:29
> +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific file I
think.

> Source/WebKit/UIProcess/mac/DisplayLink.h:28
> +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

Ditto.

> Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41
> +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) &&
ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file.