[webkit-reviews] review granted: [Bug 186429] Send display link IPC message from display link thread. : [Attachment 342280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 10:02:41 PDT 2018


Geoffrey Garen <ggaren at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 186429: Send display link IPC message from display link thread.
https://bugs.webkit.org/show_bug.cgi?id=186429

Attachment 342280: Patch

https://bugs.webkit.org/attachment.cgi?id=342280&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 342280
  --> https://bugs.webkit.org/attachment.cgi?id=342280
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342280&action=review

r=me

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:37
> -    
> +

Please revert this whitespace change to keep svn history nice.

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:102
> +    DisplayLink* displayLink = reinterpret_cast<DisplayLink*>(data);

This can be static_cast. It's slightly better to static_cast because the
compiler still enforces that you're not doing something weirder like turning a
float or an int or a CVTimeStamp* into a DisplayLink*.


More information about the webkit-reviews mailing list