[webkit-reviews] review granted: [Bug 188210] [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource : [Attachment 346222] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 23:51:29 PDT 2018


Alejandro G. Castro <alex at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 188210: [GStreamer] Make sure that first buffer running time is 0 in
GStreamerMediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=188210

Attachment 346222: Patch

https://bugs.webkit.org/attachment.cgi?id=346222&action=review




--- Comment #2 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 346222
  --> https://bugs.webkit.org/attachment.cgi?id=346222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346222&action=review

LGTM, just fix the typo.

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:51
2
> +	       auto pad = adoptGRef(gst_element_get_static_pad(self->videoSrc,
"src"));

Probably this is a small typo and you wanted to use audioSrc.


More information about the webkit-reviews mailing list