[webkit-reviews] review granted: [Bug 188193] [GStreamer] Stop pushing buffers when seeking status changes : [Attachment 346153] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 188193: [GStreamer] Stop pushing buffers when seeking status changes
https://bugs.webkit.org/show_bug.cgi?id=188193

Attachment 346153: Patch

https://bugs.webkit.org/attachment.cgi?id=346153&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 346153
  --> https://bugs.webkit.org/attachment.cgi?id=346153
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346153&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:935
> +	   if (priv->isSeeking) {
> +	       GST_TRACE_OBJECT(src, "Stopping buffer appends due to seek");
> +	       // A seek has happened in the middle of us breaking the
> +	       // incoming data up from a previous request. Stop pushing
> +	       // buffers that are now from the incorrect offset.
> +	       break;
> +	   }

I am perfectly ok with this here though I wonder if it would or not be better
to have this check at the beginning, even maybe as:

// A seek might happen while we run this pushes so we stop pushing if that
happens.
for (uint64_t currentOffset = 0; !priv->isSeeking && currentOffset <
bufferSize; currentOffset += blockSize) {