[webkit-reviews] review granted: [Bug 187631] IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins : [Attachment 345004] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 187631: IndexedDB: closeAndDeleteDatabasesForOrigins should remove all
databases for those origins
https://bugs.webkit.org/show_bug.cgi?id=187631

Attachment 345004: Patch

https://bugs.webkit.org/attachment.cgi?id=345004&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 345004
  --> https://bugs.webkit.org/attachment.cgi?id=345004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345004&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:-136
> -    auto pid = [webView _webProcessIdentifier];
> -    if (pid)
> -	   kill(pid, SIGKILL);

This seems unrelated. You mentioned you think it's the cause of some flakiness
and there's a bug for it. We should implement it over in that bug.

It seems weird that we thought we needed to reset all processes but this change
would stop doing that.