[webkit-reviews] review granted: [Bug 187702] Make sure LibWebRTCMediaEndpoint is always destroyed on the main thread : [Attachment 345098] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 16 10:36:35 PDT 2018
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187702: Make sure LibWebRTCMediaEndpoint is always destroyed on the main
thread
https://bugs.webkit.org/show_bug.cgi?id=187702
Attachment 345098: Patch
https://bugs.webkit.org/attachment.cgi?id=345098&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 345098
--> https://bugs.webkit.org/attachment.cgi?id=345098
Patch
It seems safer with the patch.
I wonder whether this is an actual issue though.
When the pc goes away, LibWebRTCMediaEndpoint::close() is called which stops
the timer.
Or is it needed to destroy the timer as well?
More information about the webkit-reviews
mailing list