[webkit-reviews] review denied: [Bug 187547] [WinCairo] run-api-tests is timing out for almost all test cases : [Attachment 344980] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 13 15:45:33 PDT 2018
Fujii Hironori <Hironori.Fujii at sony.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 187547: [WinCairo] run-api-tests is timing out for almost all test cases
https://bugs.webkit.org/show_bug.cgi?id=187547
Attachment 344980: Patch
https://bugs.webkit.org/attachment.cgi?id=344980&action=review
--- Comment #9 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 344980
--> https://bugs.webkit.org/attachment.cgi?id=344980
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=344980&action=review
> Tools/Scripts/webkitpy/port/server_process.py:308
> return
You should put the condition here instead of above.
self._proc.poll() is not None:
return
> Tools/Scripts/webkitpy/port/server_process_unittest.py:131
> + cmd = [sys.executable, '-c', 'import sys; print "stdout";
sys.stdout.flush(); print >>sys.stderr, "stderr"; sys.stderr.flush();']
All files are flushed when the process exits. You don't need to flush.
More information about the webkit-reviews
mailing list