[webkit-reviews] review granted: [Bug 187661] Crash under ApplicationCacheGroup::didFailLoadingEntry() : [Attachment 344979] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187661: Crash under ApplicationCacheGroup::didFailLoadingEntry()
https://bugs.webkit.org/show_bug.cgi?id=187661

Attachment 344979: Patch

https://bugs.webkit.org/attachment.cgi?id=344979&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 344979
  --> https://bugs.webkit.org/attachment.cgi?id=344979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344979&action=review

> Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:556
> +	   m_frame->document()->addConsoleMessage(MessageSource::AppCache,
MessageLevel::Error, "Application Cache update failed, because " +
url.stringCenterEllipsizedToLength() + (m_entryLoader &&
m_entryLoader->hasRedirection() ? " was redirected." : " could not be
fetched."));

makeString() ?