[webkit-reviews] review denied: [Bug 187360] Fix iOS crash when starting loads with no active DocumentLoader : [Attachment 344355] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 187360: Fix iOS crash when starting loads with no active DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=187360

Attachment 344355: Patch

https://bugs.webkit.org/attachment.cgi?id=344355&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 344355
  --> https://bugs.webkit.org/attachment.cgi?id=344355
Patch

Can you please give an example (even better a test case since this is crash) of
when m_documentLoader is null when this function is called? ResourceLoader
assumes we always have a non-null pointer to a document loader unless it
explicitly nullified it in ResourceLoader::releaseResources(). I mean, even in
this function, we assume a non-null m_documentLoader when we
ASSERT(!m_documentLoader->isSubstituteLoadPending(this)) at the top of this
function.