[webkit-reviews] review granted: [Bug 187123] IndexedDB operations in a Page fail after a StorageProcess crash : [Attachment 344362] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 14:01:43 PDT 2018


Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 187123: IndexedDB operations in a Page fail after a StorageProcess crash
https://bugs.webkit.org/show_bug.cgi?id=187123

Attachment 344362: Patch

https://bugs.webkit.org/attachment.cgi?id=344362&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 344362
  --> https://bugs.webkit.org/attachment.cgi?id=344362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344362&action=review

> Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp:67
> +void IDBConnectionToServer::callResultFunctionWithErrorLater(ResultFunction
function, const IDBResourceIdentifier& requestIdentifier)

It could be made more compact by passing the const IDBRequestData&


More information about the webkit-reviews mailing list