[webkit-reviews] review granted: [Bug 187331] [ews-build] WebKitPy-Tests-EWS should output result in json : [Attachment 344300] Proposed patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 187331: [ews-build] WebKitPy-Tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187331

Attachment 344300: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=344300&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 344300
  --> https://bugs.webkit.org/attachment.cgi?id=344300
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344300&action=review

r=me

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:313
> +			   command=['Tools/Scripts/test-webkitpy',
'--json-output=webkitpy_test_results.json'],
> +			   logfiles={'json': 'webkitpy_test_results.json'},

Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in
steps.py.

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:326
> +			   command=['Tools/Scripts/test-webkitpy',
'--json-output=webkitpy_test_results.json'],
> +			   logfiles={'json': 'webkitpy_test_results.json'},

Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in
steps.py.