[webkit-reviews] review granted: [Bug 187330] [ews-build] Bindings-tests-EWS should output result in json : [Attachment 344299] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 5 10:18:25 PDT 2018
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 187330: [ews-build] Bindings-tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187330
Attachment 344299: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=344299&action=review
--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 344299
--> https://bugs.webkit.org/attachment.cgi?id=344299
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=344299&action=review
r=me
> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:244
> + command=['Tools/Scripts/run-bindings-tests',
'--json-output=bindings_test_results.json'],
> + logfiles={'json': 'bindings_test_results.json'},
Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in
steps.py.
> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:256
> + command=['Tools/Scripts/run-bindings-tests',
'--json-output=bindings_test_results.json'],
> + logfiles={'json': 'bindings_test_results.json'},
Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in
steps.py.
More information about the webkit-reviews
mailing list