[webkit-reviews] review granted: [Bug 181908] Safari Tech Preview can't use GitHub login at forums.swift.org : [Attachment 331932] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 181908: Safari Tech Preview can't use GitHub login at forums.swift.org
https://bugs.webkit.org/show_bug.cgi?id=181908

Attachment 331932: Patch

https://bugs.webkit.org/attachment.cgi?id=331932&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 331932
  --> https://bugs.webkit.org/attachment.cgi?id=331932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331932&action=review

r=me with comment.

> Source/WebCore/loader/DocumentLoader.cpp:488
> +    auto tryLoadingThroughServiceWorker =
!frameLoader()->isReloadingFromOrigin() && m_frame->page() &&
RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled() &&
SchemeRegistry::canServiceWorkersHandleURLScheme(url.protocol().toStringWithout
Copying());

Variable name would be better with a *should* prefix.