[webkit-reviews] review granted: [Bug 181400] REGRESSION (r226485): Many new wasm leaks detected by the leaks bot : [Attachment 331941] disable poisoning on the bot

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 181400: REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
https://bugs.webkit.org/show_bug.cgi?id=181400

Attachment 331941: disable poisoning on the bot

https://bugs.webkit.org/attachment.cgi?id=331941&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 331941
  --> https://bugs.webkit.org/attachment.cgi?id=331941
disable poisoning on the bot

(In reply to Alexey Proskuryakov from comment #2)
> Created attachment 331941 [details]
> disable poisoning on the bot
> 
> Sounds like the short term solution is to disable poisoning on the bot. JF,
> is this likely to continue working for now?

Disabling poisoning should remain a reliable manner to avoid leaks. It looks
like you're disabling it only for the leaks bots, which is important since we
want to test with poisoning elsewhere.

If the leaks program changes in the future, say to ignore the WebKit zones, we
should make sure that with JSC_usePoisoning=0 they do detect leaks properly
(otherwise we'd just ignore the leaks).