[webkit-reviews] review granted: [Bug 181136] REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions : [Attachment 331140] Revised with Chris's comments.

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 181136: REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should
be read-only in ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=181136

Attachment 331140: Revised with Chris's comments.

https://bugs.webkit.org/attachment.cgi?id=331140&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 331140
  --> https://bugs.webkit.org/attachment.cgi?id=331140
Revised with Chris's comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=331140&action=review

r=me with comment.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:97
> +   
const_cast<Configuration*>(&m_configuration)->resourceLoadStatisticsDirectory =
API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory();

This looks a little ugly. Can we use instead:
struct Configuration {
  // ...
  String resourceLoadStatisticsDirectory
{API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory() };
}

in the header?

or add a default constructor to Configuration which always sets
resourceLoadStatisticsDirectory.