[webkit-reviews] review granted: [Bug 181505] Setting Window.opener to null should disown its opener : [Attachment 331098] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 11 16:45:40 PST 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181505: Setting Window.opener to null should disown its opener
https://bugs.webkit.org/show_bug.cgi?id=181505
Attachment 331098: Patch
https://bugs.webkit.org/attachment.cgi?id=331098&action=review
--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 331098
--> https://bugs.webkit.org/attachment.cgi?id=331098
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=331098&action=review
> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:478
> + replaceStaticPropertySlot(state.vm(), this,
Identifier::fromString(&state.vm(), reinterpret_cast<const LChar*>("opener"),
strlen("opener")), value);
Why not just Identifier::fromString(&state.vm(), "opener")?
More information about the webkit-reviews
mailing list