[webkit-reviews] review granted: [Bug 181540] [iOS] There should be no controls markup generated in fullscreen : [Attachment 331063] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 181540: [iOS] There should be no controls markup generated in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=181540

Attachment 331063: Patch

https://bugs.webkit.org/attachment.cgi?id=331063&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 331063
  --> https://bugs.webkit.org/attachment.cgi?id=331063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331063&action=review

> Source/WebCore/ChangeLog:11
> +	   "visible" flag to "false" on the MediaControls, which will prevent
any DOM content to
> +	   be added to it.

Nit: "prevent any DOM content from being added ..." might be better than
"prevent any DOM content to be added ..."