[webkit-reviews] review granted: [Bug 180851] RTCController should disable ICE candidate filtering in case of getUserMedia based on the RTCPerrConnection origin : [Attachment 331064] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 180851: RTCController should disable ICE candidate filtering in case of
getUserMedia based on the RTCPerrConnection origin
https://bugs.webkit.org/show_bug.cgi?id=180851

Attachment 331064: Patch

https://bugs.webkit.org/attachment.cgi?id=331064&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 331064
  --> https://bugs.webkit.org/attachment.cgi?id=331064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331064&action=review

> Source/WebCore/Modules/mediastream/RTCController.cpp:90
> +void RTCController::disableICECandidateFiltering(Document& document)

Nit: maybe disableICECandidateFilteringForDocument to match the pattern of
disableICECandidateFilteringForAllOrigins.