[webkit-reviews] review granted: [Bug 182353] Web Inspector: TabBar redesign: remove top-level search field and pin the Search tab : [Attachment 333991] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 182353: Web Inspector: TabBar redesign: remove top-level search field and
pin the Search tab
https://bugs.webkit.org/show_bug.cgi?id=182353

Attachment 333991: Patch

https://bugs.webkit.org/attachment.cgi?id=333991&action=review




--- Comment #16 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 333991
  --> https://bugs.webkit.org/attachment.cgi?id=333991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333991&action=review

r=me.  This looks great!  The only other piece of feedback I can think of is
that we might want to shift the Inspect button a bit now that there is a lot of
empty space, unless you have other ideas :)

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:75
> +    --open-resource-dialog-search-icon-offset-start: 10px;

Since this value matches `top`, you could use the variable there as well
(unless there is some other styling that I am not seeing).