[webkit-reviews] review granted: [Bug 182664] Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources : [Attachment 333628] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 182664: Resource Load Statistics: Classify resources as prevalent based on
redirects to other prevalent resources
https://bugs.webkit.org/show_bug.cgi?id=182664

Attachment 333628: Patch

https://bugs.webkit.org/attachment.cgi?id=333628&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 333628
  --> https://bugs.webkit.org/attachment.cgi?id=333628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333628&action=review

Looks great! r=me (but please fix the boolean initialization stuff I
mentioned).

> Source/WebCore/loader/ResourceLoadObserver.cpp:178
> +	   bool isNewRedirectFromEntry;

I would initialize these to false, just because I am pedantic that way.

> Source/WebCore/loader/ResourceLoadObserver.cpp:247
> +	   bool isNewRedirectFromEntry;

Don't declare these up here. Just declare them at initialization.

> Source/WebCore/loader/ResourceLoadObserver.cpp:249
> +	   isNewRedirectToEntry =
redirectingOriginStatistics.subresourceUniqueRedirectsTo.add(targetPrimaryDomai
n).isNewEntry;

bool isNewRedirectToEntry = redirectingOrigin....

> Source/WebCore/loader/ResourceLoadObserver.cpp:251
> +	   isNewRedirectFromEntry =
targetStatistics.subresourceUniqueRedirectsFrom.add(sourcePrimaryDomain).isNewE
ntry;

bool isNewRedirectFromEntry = targetStatistics.subresource...